Skip to content

fix(test): make //tests:path_test work on Windows #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgrindel merged 1 commit into from
Feb 7, 2026
+2 −3
Merged

fix(test): make //tests:path_test work on Windows #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .bazelci/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ win_tests: &win_tests
- "//tests/..."
- "//toolchains/..."
- "-//tests:package_naming_aggregate_test"
- "-//tests:path_test"
# Bazel might be broken w.r.t. Unicode processing for windows. Multiple issues:
# https://github.com/bazelbuild/bazel/issues?q=is%3Aissue+is%3Aopen+%2Bunicode+%2Bwindows+
- "-//tests/mappings:utf8_manifest_test"
Expand Down
4 changes: 2 additions & 2 deletions tests/path_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import collections
import imp
import os
import posixpath
import unittest


Expand All @@ -37,7 +37,7 @@ def __init__(self, short_path, is_generated=False, is_external=False):
else:
self.owner = Owner('', '')
self.short_path = short_path
self.path = os.path.join(
self.path = posixpath.join(
self.root.path, self.owner.workspace_root, short_path)


Expand Down