fix(test): make //tests:path_test work on Windows#1017
Merged
cgrindel merged 1 commit intobazelbuild:mainfrom Feb 7, 2026
Merged
fix(test): make //tests:path_test work on Windows#1017cgrindel merged 1 commit intobazelbuild:mainfrom
//tests:path_test work on Windows#1017cgrindel merged 1 commit intobazelbuild:mainfrom
Conversation
rdesgroppes
force-pushed
the
fix-path-test-windows
branch
from
3f2ffbd to
1609a80
Compare
The test was failing on Windows: ``` FAIL: testDestPathExt (__main__.DestPathTest.testDestPathExt) AssertionError: '/bar/baz' != 'external/repo\\foo/bar/baz' FAIL: testDestPathExtWrong (__main__.DestPathTest.testDestPathExtWrong) AssertionError: 'external/repo/foo/bar/baz' != 'external/repo\\foo/bar/baz' FAIL: testSafeShortPathExt (__main__.SafeShortPathTest.testSafeShortPathExt) AssertionError: 'external/repo/foo/bar/baz' != 'external/repo\\foo/bar/baz' FAIL: testSafeShortPathGenExt (__main__.SafeShortPathTest.testSafeShortPathGenExt) AssertionError: 'external/repo/foo/bar/baz' != 'external/repo\\foo/bar/baz' FAIL: testShortPathDirnameExt (__main__.ShortPathDirnameTest.testShortPathDirnameExt) AssertionError: 'external/repo/foo/bar' != 'external/repo\\foo/bar' FAIL: testShortPathDirnameGenExt (__main__.ShortPathDirnameTest.testShortPathDirnameGenExt) AssertionError: 'external/repo/foo/bar' != 'external/repo\\foo/bar' FAIL: testTopLevelExt (__main__.ShortPathDirnameTest.testTopLevelExt) AssertionError: 'external/repo' != 'external' ``` The mock `File` class used `os.path.join()` which produces platform-specific path separators (backslashes on Windows), which doesn't match Bazel's behavior which always uses forward slashes regardless of platform: - use `posixpath.join()` instead, - enable the test in Windows CI since it now passes.
rdesgroppes
force-pushed
the
fix-path-test-windows
branch
from
1609a80 to
2c320e9
Compare
rdesgroppes
requested review from
aiuto,
cgrindel and
meteorcloudy
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was failing on Windows:
The mock
Fileclass usedos.path.join()which produces platform-specific path separators (backslashes on Windows), which doesn't match Bazel's behavior which always uses forward slashes regardless of platform:posixpath.join()instead,