fix: do not run platform sensitive tests in doc #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc gives a very good example of how one can ignore tests depending on the platform it's running on. But when we check this part of the doc, depending on the platform we're doing it, we don't get the same output, hence the doc_test fails on mac and succeeds on linux. So to ensure doc test is portable we just don't check this part of the doc.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc gives a very good example of how one can ignore tests depending on the platform it's running on. But when we check this part of the doc, depending on the platform we're doing it, we don't get the same output, hence the doc_test fails on mac and succeeds on linux.
So to ensure doc test is portable we just don't check this part of the doc.