fix: make tests/test_doc.sh pass on macOS
#143
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The skip_if example in README.adoc produced different output on Linux vs macOS due to alphabetical test ordering. Renamed the test functions to sort consistently and added platform-specific output markers (`output-linux` and `output-darwin`) that `test_doc.sh` selects based on uname.
Contributor
Author
|
Hmm, didn't work as intended. Will rethink. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is a work in progress. Do not merge.
The skip_if example in README.adoc produced different output on Linux vs macOS due to alphabetical test ordering. Renamed the test functions to sort consistently and added platform-specific output markers (
output-linuxandoutput-darwin) thattest_doc.shselects based on uname.Another approach could be to just skip this on Darwin or add a way to skip certain tests in
test_doc.sh.Todo