fix: update durable execution stop test for new emulator behavior#8906
Merged
reedham-aws merged 1 commit intodevelopfrom Apr 8, 2026
Merged
fix: update durable execution stop test for new emulator behavior#8906reedham-aws merged 1 commit intodevelopfrom
reedham-aws merged 1 commit intodevelopfrom
Conversation
Contributor
Author
|
Integration test run for confirmation: https://github.com/aws/aws-sam-cli/actions/runs/24146855431 |
9 tasks
yaythomas
approved these changes
Apr 8, 2026
SilanHe
approved these changes
Apr 8, 2026
roger-zhangg
approved these changes
Apr 8, 2026
tobixlea
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
The durable execution emulator has been updated to have idempotent responses for
StopDurableExecution(aws/aws-durable-execution-sdk-python-testing#195). Previously, our integration tests had been assuming that the responses were not idempotent and testing against that, causing the tests to fail.How does it address the issue?
Update the test so that the expected error code matches what is returned in the idempotent case.\
What side effects does this change have?
Slightly less rigorous testing on the message returned from
StopDurableExecution. I think this is fine because it allows us decouple from what the emulator returns for a string, in case that changes.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.