Skip to content

fix: update durable execution stop test for new emulator behavior#8906

Merged
reedham-aws merged 1 commit intodevelopfrom
local-exec-test
Apr 8, 2026
Merged

fix: update durable execution stop test for new emulator behavior#8906
reedham-aws merged 1 commit intodevelopfrom
local-exec-test

Conversation

@reedham-aws
Copy link
Copy Markdown
Contributor

Why is this change necessary?

The durable execution emulator has been updated to have idempotent responses for StopDurableExecution (aws/aws-durable-execution-sdk-python-testing#195). Previously, our integration tests had been assuming that the responses were not idempotent and testing against that, causing the tests to fail.

How does it address the issue?

Update the test so that the expected error code matches what is returned in the idempotent case.\

What side effects does this change have?

Slightly less rigorous testing on the message returned from StopDurableExecution. I think this is fine because it allows us decouple from what the emulator returns for a string, in case that changes.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@reedham-aws reedham-aws requested a review from a team as a code owner April 8, 2026 16:34
@reedham-aws
Copy link
Copy Markdown
Contributor Author

Integration test run for confirmation: https://github.com/aws/aws-sam-cli/actions/runs/24146855431

@reedham-aws reedham-aws changed the title fix: update durable execution stop test for new behavior fix: update durable execution stop test for new emulator behavior Apr 8, 2026
@reedham-aws reedham-aws added this pull request to the merge queue Apr 8, 2026
Merged via the queue into develop with commit 4e13a91 Apr 8, 2026
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants