Revert "Feat/use durable functions emulator image (#8708)"#8896
Closed
reedham-aws wants to merge 1 commit intoaws:developfrom
Closed
Revert "Feat/use durable functions emulator image (#8708)"#8896reedham-aws wants to merge 1 commit intoaws:developfrom
reedham-aws wants to merge 1 commit intoaws:developfrom
Conversation
This reverts commit 4e47788.
seshubaws
approved these changes
Apr 7, 2026
Contributor
Author
|
Integration test run just because this revert is to verify the integ tests work: https://github.com/aws/aws-sam-cli/actions/runs/24109630940 |
Member
|
I think this is because of aws/aws-durable-execution-sdk-python-testing#195, the integration test that's failing is expecting the wrong behaviour. |
Contributor
Author
|
Superseded by the actual integration test fix: #8906. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4e47788.
Which issue(s) does this change fix?
Since merging #8708, we've seen a consistent failure in the durable functions integration tests related to the
sam local execution stopcommand not properly returning an error code when attempting to stop an already stopped execution.Why is this change necessary?
The root cause of the failures remains unclear, and thus reverting is the easiest path forward.
How does it address the issue?
Reverts the code that introduced the changes.
What side effects does this change have?
The durable functions emulator will remain bundled with the SAM CLI installation, rather than pulled directly from ECR. Once this issue is fixed, we will return to using the emulator from ECR.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.