Skip to content

Revert "Feat/use durable functions emulator image (#8708)"#8896

Closed
reedham-aws wants to merge 1 commit intoaws:developfrom
reedham-aws:durable-revert
Closed

Revert "Feat/use durable functions emulator image (#8708)"#8896
reedham-aws wants to merge 1 commit intoaws:developfrom
reedham-aws:durable-revert

Conversation

@reedham-aws
Copy link
Copy Markdown
Contributor

This reverts commit 4e47788.

Which issue(s) does this change fix?

Since merging #8708, we've seen a consistent failure in the durable functions integration tests related to the sam local execution stop command not properly returning an error code when attempting to stop an already stopped execution.

Why is this change necessary?

The root cause of the failures remains unclear, and thus reverting is the easiest path forward.

How does it address the issue?

Reverts the code that introduced the changes.

What side effects does this change have?

The durable functions emulator will remain bundled with the SAM CLI installation, rather than pulled directly from ECR. Once this issue is fixed, we will return to using the emulator from ECR.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@reedham-aws reedham-aws requested a review from a team as a code owner April 7, 2026 23:31
@reedham-aws
Copy link
Copy Markdown
Contributor Author

Integration test run just because this revert is to verify the integ tests work: https://github.com/aws/aws-sam-cli/actions/runs/24109630940

@bchampp
Copy link
Copy Markdown
Member

bchampp commented Apr 8, 2026

I think this is because of aws/aws-durable-execution-sdk-python-testing#195, the integration test that's failing is expecting the wrong behaviour.

@reedham-aws
Copy link
Copy Markdown
Contributor Author

Superseded by the actual integration test fix: #8906.

@reedham-aws reedham-aws closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants