Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# AWS Durable Execution SDK for Python

[![Build](https://github.com/aws/aws-durable-execution-sdk-python/actions/workflows/ci.yml/badge.svg)](https://github.com/aws/aws-durable-execution-sdk-python/actions/workflows/ci.yml)
[![Core Conformance](https://github.com/aws/aws-durable-execution-sdk-python/actions/workflows/conformance-tests.yml/badge.svg)](https://github.com/aws/aws-durable-execution-sdk-python/actions/workflows/conformance-tests.yml)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude AI review

The Core Conformance badge will render "no status" rather than a pass/fail state. GitHub status badges (with no ?branch=/?event= query) reflect the most recent run on the default branch (main), but conformance-tests.yml only triggers on pull_request and workflow_dispatch (.github/workflows/conformance-tests.yml:7-14) — it has no push: branches: [main] trigger. pull_request runs are attributed to the PR head branch, not main, so nothing populates the default-branch status. Contrast this with the working ci.yml badge and the OpenTelemetry badge added just below, both of whose workflows include push: branches: [main].

Concrete fix: add a push: branches: ["main"] trigger to conformance-tests.yml (matching opentelemetry-conformance-tests.yml) so the badge reflects real status. Note that the conformance workflow deploys to shared AWS stacks under a global concurrency lock, so if running it on every push to main is undesirable, prefer removing this badge (or replacing it with one that points at a workflow that does run on main) rather than shipping a badge that permanently shows "no status".

[![OpenTelemetry Conformance](https://github.com/aws/aws-durable-execution-sdk-python/actions/workflows/opentelemetry-conformance-tests.yml/badge.svg)](https://github.com/aws/aws-durable-execution-sdk-python/actions/workflows/opentelemetry-conformance-tests.yml)
[![PyPI - Version](https://img.shields.io/pypi/v/aws-durable-execution-sdk-python.svg)](https://pypi.org/project/aws-durable-execution-sdk-python)
[![PyPI - Python Version](https://img.shields.io/pypi/pyversions/aws-durable-execution-sdk-python.svg)](https://pypi.org/project/aws-durable-execution-sdk-python)
[![OpenSSF Scorecard](https://api.scorecard.dev/projects/github.com/aws/aws-durable-execution-sdk-python/badge)](https://scorecard.dev/viewer/?uri=github.com/aws/aws-durable-execution-sdk-python)
Expand Down
Loading