docs: add conformance status badges - #657
Conversation
| # AWS Durable Execution SDK for Python | ||
|
|
||
| [](https://github.com/aws/aws-durable-execution-sdk-python/actions/workflows/ci.yml) | ||
| [](https://github.com/aws/aws-durable-execution-sdk-python/actions/workflows/conformance-tests.yml) |
There was a problem hiding this comment.
Claude AI review
The Core Conformance badge will render "no status" rather than a pass/fail state. GitHub status badges (with no ?branch=/?event= query) reflect the most recent run on the default branch (main), but conformance-tests.yml only triggers on pull_request and workflow_dispatch (.github/workflows/conformance-tests.yml:7-14) — it has no push: branches: [main] trigger. pull_request runs are attributed to the PR head branch, not main, so nothing populates the default-branch status. Contrast this with the working ci.yml badge and the OpenTelemetry badge added just below, both of whose workflows include push: branches: [main].
Concrete fix: add a push: branches: ["main"] trigger to conformance-tests.yml (matching opentelemetry-conformance-tests.yml) so the badge reflects real status. Note that the conformance workflow deploys to shared AWS stacks under a global concurrency lock, so if running it on every push to main is undesirable, prefer removing this badge (or replacing it with one that points at a workflow that does run on main) rather than shipping a badge that permanently shows "no status".
Codex AI reviewNo actionable findings. Both badge URLs match existing workflow filenames. Residual risk: live badge rendering and status responses were not network-validated. Reviewed commit |
Claude AI reviewThis PR adds two README conformance badges. Both referenced workflow files exist and both badge/link URLs are well-formed. The OpenTelemetry Conformance badge will work correctly because One actionable issue: the Core Conformance badge (README line 4) points at Residual test risk: none beyond the badge-rendering behavior noted above; this is a docs-only change and cannot be exercised by the repo's test suites (verified in CI only after merge to Reviewed commit |
Summary
Testing
git diff --checkmain