SLING-13138 Add configurable fail-fast parameter limit handling#74
Open
aswinad wants to merge 3 commits intoapache:masterfrom
Open
SLING-13138 Add configurable fail-fast parameter limit handling#74aswinad wants to merge 3 commits intoapache:masterfrom
aswinad wants to merge 3 commits intoapache:masterfrom
Conversation
joerghoh
approved these changes
Mar 16, 2026
Contributor
joerghoh
left a comment
joerghoh
left a comment
There was a problem hiding this comment.
LGTM
although I have never seen that warning being written (highly doubt that as the default size is 10k), so I question a bit the value of it. But fixing TODOs is definitely good.
Contributor
Author
|
Thanks! The main goal here was addressing the TODO and making the behavior configurable. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SLING-13138
Improve request parameter limit handling in ParameterMap.
This change updates the parameter limit check from
size() == maxParametersto
size() >= maxParametersfor more defensive boundary handling.It also introduces an optional configuration to control behavior when the
configured parameter limit is exceeded:
The default behavior remains unchanged for backward compatibility.
Unit tests are included for both modes.