SLING-13137 Improve logging when file logger creation fails#73
Merged
joerghoh merged 3 commits intoapache:masterfrom Mar 25, 2026
Merged
Conversation
joerghoh
reviewed
Mar 16, 2026
src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java
Outdated
Show resolved
Hide resolved
joerghoh
approved these changes
Mar 16, 2026
Contributor
joerghoh
left a comment
joerghoh
left a comment
There was a problem hiding this comment.
lgtm with a tiny nitpick.
…rvice.java Co-authored-by: Jörg Hoh <joerghoh@users.noreply.github.com>
|
Contributor
Author
|
Thanks! Applied the suggestion. |
Contributor
Author
Contributor
|
thanks @aswinad for your contribution! it's applied now. Can you update the ticket:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SLING-13105
Improve diagnostics when file logger creation fails in RequestLoggerService.
When an IOException occurs during file logger creation, the error is now
logged using SLF4J and includes the resolved absolute log file path.
This makes configuration issues easier to diagnose while preserving
the existing fallback behavior.
Changes: