[ISSUE #10438] Fix buildTopicConfigSerializeWrapper exposing live topicConfigTable reference#10439
Open
chuanxo wants to merge 1 commit into
Open
Conversation
…ve topicConfigTable reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildTopicConfigSerializeWrapper()直接将this.topicConfigTable引用设入 wrapper，与dataVersion的 copy 之间存在并发不一致new ConcurrentHashMap<>(this.topicConfigTable)做浅拷贝，保证 wrapper 是 point-in-time 一致快照Fixes #10438
Test plan
testSerializeWrapperIsSnapshot验证 wrapper 持有独立 snapshot，后续写入不可见TopicConfigManagerTest13 个用例通过