Skip to content

RANGER-5610:getResourceACLs for a principal should consider validitySchedule of principal for ACL creation #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rameeshm wants to merge 2 commits into
base: master
Choose a base branch
from
+457 −0
Open

RANGER-5610:getResourceACLs for a principal should consider validitySchedule of principal for ACL creation #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
401dbdc
RANGER-5610:getResourceACLs for a principal should consider validityS…
May 29, 2026
9621a17
RANGER-5610:getResourceACLs for a principal should consider validityS…
May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
179 changes: 179 additions & 0 deletions ...t/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import org.apache.hadoop.thirdparty.com.google.common.collect.Sets;
import org.apache.ranger.authorization.hadoop.constants.RangerHadoopConstants;
import org.apache.ranger.authorization.utils.StringUtil;
import org.apache.ranger.plugin.conditionevaluator.RangerValidityScheduleConditionEvaluator;
import org.apache.ranger.plugin.model.RangerPolicy;
import org.apache.ranger.plugin.model.RangerPolicy.RangerPolicyItemAccess;
import org.apache.ranger.plugin.model.RangerRole;
Expand All @@ -69,6 +70,7 @@
import org.apache.ranger.plugin.policyengine.RangerAccessResult;
import org.apache.ranger.plugin.policyengine.RangerPolicyEngine;
import org.apache.ranger.plugin.policyengine.RangerResourceACLs;
import org.apache.ranger.plugin.policyengine.gds.GdsPolicyEngine;
import org.apache.ranger.plugin.policyevaluator.RangerPolicyEvaluator;
import org.apache.ranger.plugin.service.RangerBasePlugin;
import org.apache.ranger.plugin.util.GrantRevokeRequest;
Expand All @@ -77,6 +79,7 @@
import org.apache.ranger.plugin.util.RangerPerfTracer;
import org.apache.ranger.plugin.util.RangerRequestedResources;
import org.apache.ranger.plugin.util.RangerRoles;
import org.apache.ranger.plugin.util.ServiceDefUtil;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -2843,11 +2846,187 @@ private RangerResourceACLs getRangerResourceACLs(HivePrivilegeObject hiveObject,

ret = hivePlugin.getResourceACLs(request);

if (ret != null && principal != null && request != null) {
filterAclsByValiditySchedule(ret, principal, request);
}

LOG.debug("<== RangerHivePolicyProvider.getRangerResourceACLs:[{}], principal=[{}], Computed ACLS:[{}]", hiveObject, principal, ret);

return ret;
}

private void filterAclsByValiditySchedule(RangerResourceACLs acls, HivePrincipal principal, RangerAccessRequest request) {
if (acls == null || principal == null || request == null) {
return;
}

Map<String, Map<String, RangerResourceACLs.AccessResult>> principalACLs = null;
switch (principal.getType()) {
case USER:
principalACLs = acls.getUserACLs();
break;
case GROUP:
principalACLs = acls.getGroupACLs();
break;
case ROLE:
principalACLs = acls.getRoleACLs();
break;
default:
break;
}

if (principalACLs != null) {
Map<String, RangerResourceACLs.AccessResult> accessMap = principalACLs.get(principal.getName());
if (accessMap != null) {
Map<String, Collection<String>> impliedGrants = null;
Map<String, Collection<String>> gdsImpliedGrants = null;

if (hivePlugin != null) {
Copy link
Copy Markdown
Contributor

@mneethiraj mneethiraj Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hivePlugin will not null here given the caller already references it at line 2847. I suggest removing the if at 2884.

RangerServiceDef serviceDef = hivePlugin.getServiceDef();
if (serviceDef != null) {
Copy link
Copy Markdown
Contributor

@mneethiraj mneethiraj Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing this if block by initializing impliedGrants in line 2881 with:

final Map<String, Collection<String>> impliedGrants = hivePlugin.getServiceDefHelper() != null ? hivePlugin.getServiceDefHelper().getImpliedAccessGrants() : Collections.emptyMap();

impliedGrants = ServiceDefUtil.getExpandedImpliedGrants(serviceDef);
}

GdsPolicyEngine gdsPolicyEngine = hivePlugin.getGdsPolicyEngine();
if (gdsPolicyEngine != null && gdsPolicyEngine.getGdsInfo() != null) {
RangerServiceDef gdsServiceDef = gdsPolicyEngine.getGdsInfo().getGdsServiceDef();
Copy link
Copy Markdown
Contributor

@mneethiraj mneethiraj Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating GdsPolicyEngine to expose RangerServiceDefHelper and use it to initialize gdsImpliedGrants in line 2882.

final Map<String, Collection<String>> gdsImpliedGrants = gdsPolicyEngine != null && gdsPolicyEngine.getServiceDefHelper() != null ? gdsPolicyEngine.getServiceDefHelper().getImpliedAccessGrants() : Collections.emptyMap();

if (gdsServiceDef != null) {
gdsImpliedGrants = ServiceDefUtil.getExpandedImpliedGrants(gdsServiceDef);
}
}
}

Map<RangerPolicy.RangerPolicyItem, Boolean> policyItemActiveCache = new HashMap<>();
List<String> keysToRemove = new ArrayList<>();
Copy link
Copy Markdown
Contributor

@mneethiraj mneethiraj Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keysToRemove ==> permissionsToRemove

for (Map.Entry<String, RangerResourceACLs.AccessResult> entry : accessMap.entrySet()) {
RangerResourceACLs.AccessResult accessResult = entry.getValue();
if (accessResult != null && accessResult.getResult() == RangerPolicyEvaluator.ACCESS_CONDITIONAL) {
RangerPolicy policy = accessResult.getPolicy();
if (policy != null) {
boolean hasActiveItem = false;

List<RangerPolicy.RangerPolicyItem> policyItems = new ArrayList<>();
if (CollectionUtils.isNotEmpty(policy.getPolicyItems())) {
policyItems.addAll(policy.getPolicyItems());
}
if (CollectionUtils.isNotEmpty(policy.getDenyPolicyItems())) {
policyItems.addAll(policy.getDenyPolicyItems());
}
if (CollectionUtils.isNotEmpty(policy.getAllowExceptions())) {
policyItems.addAll(policy.getAllowExceptions());
}
if (CollectionUtils.isNotEmpty(policy.getDenyExceptions())) {
policyItems.addAll(policy.getDenyExceptions());
}

for (RangerPolicy.RangerPolicyItem policyItem : policyItems) {
if (isPolicyItemApplicable(policyItem, principal, entry.getKey(), impliedGrants, gdsImpliedGrants)) {
Boolean isActive = policyItemActiveCache.get(policyItem);
if (isActive == null) {
isActive = isPolicyItemValidityActive(policyItem, request);
policyItemActiveCache.put(policyItem, isActive);
}
if (isActive) {
hasActiveItem = true;
break;
}
}
}
if (!hasActiveItem) {
keysToRemove.add(entry.getKey());
Copy link
Copy Markdown
Contributor

@mneethiraj mneethiraj Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rameeshm - if multiple policies grant this permission to the principal, removing the permission based on just one policy (line 2904) will result in incorrect ACLs.

}
}
}
}
for (String key : keysToRemove) {
accessMap.remove(key);
}
if (accessMap.isEmpty()) {
principalACLs.remove(principal.getName());
}
}
}
}

private boolean isPolicyItemApplicable(RangerPolicy.RangerPolicyItem policyItem, HivePrincipal principal, String accessType, Map<String, Collection<String>> impliedGrants, Map<String, Collection<String>> gdsImpliedGrants) {
if (policyItem == null || principal == null || StringUtils.isBlank(accessType)) {
return false;
}

if (CollectionUtils.isEmpty(policyItem.getAccesses())) {
return false;
}

boolean hasAccessType = false;

for (RangerPolicy.RangerPolicyItemAccess access : policyItem.getAccesses()) {
if (StringUtils.equalsIgnoreCase(accessType, access.getType()) || StringUtils.equalsIgnoreCase(access.getType(), RangerPolicyEngine.ANY_ACCESS)) {
hasAccessType = true;
break;
}
if (impliedGrants != null) {
Collection<String> impliedAccessTypes = impliedGrants.get(access.getType());
if (impliedAccessTypes != null) {
for (String impliedAccessType : impliedAccessTypes) {
if (StringUtils.equalsIgnoreCase(accessType, impliedAccessType)) {
hasAccessType = true;
break;
}
}
}
}
if (hasAccessType) {
break;
}
if (gdsImpliedGrants != null) {
Collection<String> impliedAccessTypes = gdsImpliedGrants.get(access.getType());
if (impliedAccessTypes != null) {
for (String impliedAccessType : impliedAccessTypes) {
if (StringUtils.equalsIgnoreCase(accessType, impliedAccessType)) {
hasAccessType = true;
break;
}
}
}
}
if (hasAccessType) {
break;
}
}

if (!hasAccessType) {
return false;
}

switch (principal.getType()) {
case USER:
return CollectionUtils.isNotEmpty(policyItem.getUsers()) && (policyItem.getUsers().contains(principal.getName()) || policyItem.getUsers().contains(RangerPolicyEngine.USER_CURRENT));
case GROUP:
return CollectionUtils.isNotEmpty(policyItem.getGroups()) && (policyItem.getGroups().contains(principal.getName()) || policyItem.getGroups().contains(RangerPolicyEngine.GROUP_PUBLIC));
case ROLE:
return CollectionUtils.isNotEmpty(policyItem.getRoles()) && policyItem.getRoles().contains(principal.getName());
}
return false;
}

private boolean isPolicyItemValidityActive(RangerPolicy.RangerPolicyItem policyItem, RangerAccessRequest request) {
if (policyItem == null || request == null || CollectionUtils.isEmpty(policyItem.getConditions())) {
return true;
}
for (RangerPolicy.RangerPolicyItemCondition condition : policyItem.getConditions()) {
if (!StringUtils.equalsIgnoreCase(condition.getType(), "validitySchedule")) {
continue;
}
RangerValidityScheduleConditionEvaluator evaluator = new RangerValidityScheduleConditionEvaluator();
evaluator.setPolicyItemCondition(condition);
evaluator.init();
if (!evaluator.isMatched(request)) {
return false;
}
}
return true;
}

private Map<String, Map<Privilege, AccessResult>> convertRangerACLsToHiveACLs(Map<String, Map<String, RangerResourceACLs.AccessResult>> rangerACLs) {
Map<String, Map<Privilege, AccessResult>> ret = new HashMap<>();

Expand Down
Loading
Loading