RANGER-5610:getResourceACLs for a principal should consider validitySchedule of principal for ACL creation#988
Open
rameeshm wants to merge 2 commits into
Open
RANGER-5610:getResourceACLs for a principal should consider validitySchedule of principal for ACL creation#988rameeshm wants to merge 2 commits into
rameeshm wants to merge 2 commits into
Conversation
…chedule of principal for ACL creation Signed-off-by: Ramesh Mani <rmani@apache.org>
…chedule of principal for ACL creation -include implied grants in policy item selection
Contributor
Author
|
@mneethiraj Please review this patch. Thanks. |
mneethiraj
reviewed
Jun 2, 2026
| Map<String, Collection<String>> impliedGrants = null; | ||
| Map<String, Collection<String>> gdsImpliedGrants = null; | ||
|
|
||
| if (hivePlugin != null) { |
Contributor
There was a problem hiding this comment.
hivePlugin will not null here given the caller already references it at line 2847. I suggest removing the if at 2884.
|
|
||
| if (hivePlugin != null) { | ||
| RangerServiceDef serviceDef = hivePlugin.getServiceDef(); | ||
| if (serviceDef != null) { |
Contributor
There was a problem hiding this comment.
Consider replacing this if block by initializing impliedGrants in line 2881 with:
final Map<String, Collection<String>> impliedGrants = hivePlugin.getServiceDefHelper() != null ? hivePlugin.getServiceDefHelper().getImpliedAccessGrants() : Collections.emptyMap();
|
|
||
| GdsPolicyEngine gdsPolicyEngine = hivePlugin.getGdsPolicyEngine(); | ||
| if (gdsPolicyEngine != null && gdsPolicyEngine.getGdsInfo() != null) { | ||
| RangerServiceDef gdsServiceDef = gdsPolicyEngine.getGdsInfo().getGdsServiceDef(); |
Contributor
There was a problem hiding this comment.
Consider updating GdsPolicyEngine to expose RangerServiceDefHelper and use it to initialize gdsImpliedGrants in line 2882.
final Map<String, Collection<String>> gdsImpliedGrants = gdsPolicyEngine != null && gdsPolicyEngine.getServiceDefHelper() != null ? gdsPolicyEngine.getServiceDefHelper().getImpliedAccessGrants() : Collections.emptyMap();
| } | ||
|
|
||
| Map<RangerPolicy.RangerPolicyItem, Boolean> policyItemActiveCache = new HashMap<>(); | ||
| List<String> keysToRemove = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
keysToRemove ==> permissionsToRemove
| } | ||
| } | ||
| if (!hasActiveItem) { | ||
| keysToRemove.add(entry.getKey()); |
Contributor
There was a problem hiding this comment.
@rameeshm - if multiple policies grant this permission to the principal, removing the permission based on just one policy (line 2904) will result in incorrect ACLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
getResourceACLs for a principal should consider validitySchedule of principal for ACL creation. Currently getResourceACLs returns a set of ACLs for the principal but if the principal is has a validity period which is expired, it is giving the ACLs which are there which is not correct.
This scenario occurs in GDS where a principal validity period is expired and ACL still show the access given, even though there is no access.
Show Privileges in RangerHiveAuthorizer uses the getResourceACLs which also result in wrong permission sets shown when the principal validity period expired. Fix will filter the getResourceACLs for the Prinicipal in RangerHiveAuthorizer if the validitySchedule is not allowing the access for the resource.
How was this patch tested?
Tested in Local VM and Unit Tests.