Skip to content

refactor: replace std::vformat with std::format for ListType|MapType::ToString #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 1 commit into from
Jan 29, 2026
Merged

refactor: replace std::vformat with std::format for ListType|MapType::ToString #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/iceberg/type.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ TypeId ListType::type_id() const { return kTypeId; }
const SchemaField& ListType::element() const { return element_; }

std::string ListType::ToString() const {
return std::vformat("list<{}>", std::make_format_args(element_));
return std::format("list<{}>", element_.ToString());
}

std::span<const SchemaField> ListType::fields() const { return {&element_, 1}; }
Expand Down Expand Up @@ -213,7 +213,7 @@ const SchemaField& MapType::value() const { return fields_[1]; }
TypeId MapType::type_id() const { return kTypeId; }

std::string MapType::ToString() const {
return std::vformat("map<{}: {}>", std::make_format_args(key(), value()));
return std::format("map<{}: {}>", key().ToString(), value().ToString());
}

std::span<const SchemaField> MapType::fields() const { return fields_; }
Expand Down
Loading