HIVE-29420: Hive ACID: Cleaner mishandles retries of killed compactions #6281
+727
−508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
force-pushed
the
cleaner-fix
branch
from
427c785 to
dea31f2
Compare
asf-ci-hive
added
tests pending
tests unstable
tests failed
and removed
tests unstable
tests pending
labels
deniskuzZ
force-pushed
the
cleaner-fix
branch
from
e7d2384 to
2313e42
Compare
deniskuzZ
changed the title
deniskuzZ
force-pushed
the
cleaner-fix
branch
from
558170a to
5919458
Compare
deniskuzZ
force-pushed
the
cleaner-fix
branch
from
5919458 to
8af6c57
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
deniskuzZ
force-pushed
the
cleaner-fix
branch
2 times, most recently
from
58663a0 to
e2058e1
Compare
deniskuzZ
force-pushed
the
cleaner-fix
branch
from
ebcc557 to
b9d4ac1
Compare
kuczoram
reviewed
Jan 29, 2026
Contributor
kuczoram
left a comment
kuczoram
left a comment
There was a problem hiding this comment.
Thanks a lot Denys for this patch! Overall it looks good, the test cases also look good. The second testcase indeed can reproduce the issue with the two bases (if the assert is disabled).
I have one question about the SQL query modification.
...ver/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/queries/ReadyToCleanHandler.java
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
deniskuzZ
force-pushed
the
cleaner-fix
branch
from
b9d4ac1 to
f29a40b
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
kuczoram
approved these changes
Jan 30, 2026
deniskuzZ
force-pushed
the
cleaner-fix
branch
from
f29a40b to
a7dc666
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TxnUtils#createValidTxnListForCleanerfindReadyToCleaneligibility condition inReadyToCleanHandler(i.e. CQ_HIGHEST_WRITE_ID < MIN_OPEN_WRITE_ID - 1)
addWriteIdsToMinHistoryfrom AcidCompactionServicerevokeTimedoutWorkersWhy are the changes needed?
Compaction retries triggered by timeouts under an incorrect configuration pose a risk of data loss. If a compaction is re-attempted before the prior attempt has completed or been properly aborted, the Cleaner may observe multiple base directories with the same writeId and erroneously delete all of them.
Does this PR introduce any user-facing change?
No
How was this patch tested?
TestCleanerWithMinHistoryWriteId