Skip to content

Commit b9d4ac1

Browse files
committed
add coverage for useMinHistoryWriteId in TestCleanerWithReplication
1 parent 737ee96 commit b9d4ac1

1 file changed

Lines changed: 23 additions & 0 deletions

File tree

itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCleanerWithReplication.java

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,34 @@
3737
import org.junit.Before;
3838
import org.junit.BeforeClass;
3939
import org.junit.Test;
40+
import org.junit.runner.RunWith;
41+
import org.junit.runners.Parameterized;
4042

4143
import java.io.IOException;
44+
import java.util.Arrays;
45+
import java.util.Collection;
4246

4347
import static org.junit.Assert.assertEquals;
4448

49+
@RunWith(Parameterized.class)
4550
public class TestCleanerWithReplication extends CompactorTest {
51+
4652
private Path cmRootDirectory;
4753
private static MiniDFSCluster miniDFSCluster;
4854
private final String dbName = "TestCleanerWithReplication";
4955

56+
private final boolean useMinHistoryWriteId;
57+
58+
public TestCleanerWithReplication(boolean useMinHistoryWriteId) {
59+
this.useMinHistoryWriteId = useMinHistoryWriteId;
60+
}
61+
62+
@Parameterized.Parameters(name = "useMinHistoryWriteId={0}")
63+
public static Collection<Object[]> parameters() {
64+
return Arrays.asList(
65+
new Object[][]{{true}, {false}});
66+
}
67+
5068
@Before
5169
public void setup() throws Exception {
5270
HiveConf conf = new HiveConf();
@@ -63,6 +81,11 @@ public void setup() throws Exception {
6381
ms.createDatabase(db);
6482
}
6583

84+
@Override
85+
protected boolean useMinHistoryWriteId() {
86+
return useMinHistoryWriteId;
87+
}
88+
6689
@BeforeClass
6790
public static void classLevelSetup() throws IOException {
6891
Configuration hadoopConf = new Configuration();

0 commit comments

Comments
 (0)