Skip to content

Conversation

@mnpoonia
Copy link
Contributor

@mnpoonia mnpoonia commented Jan 11, 2026

…ty 2.x syntax

HBASE-29820

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 45s master passed
+1 💚 compile 6m 43s master passed
+1 💚 spotless 0m 57s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 21s the patch passed
+1 💚 compile 6m 41s the patch passed
+1 💚 javac 6m 41s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 hadoopcheck 13m 18s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 51s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 48s The patch does not generate ASF License warnings.
45m 59s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7614
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname Linux 897c658d5e47 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5f173ea
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/console
versions git=2.34.1 maven=3.9.8 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia
Copy link
Contributor Author

@stoty @Apache9 FYI. This change and one more that i am working seems to be a pre-requisite to update apache parent to anything greater than 29. We are currently on 23.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 36s master passed
+1 💚 compile 1m 32s master passed
+1 💚 javadoc 0m 52s master passed
+1 💚 shadedjars 4m 33s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 14s the patch passed
+1 💚 compile 1m 33s the patch passed
+1 💚 javac 1m 33s the patch passed
+1 💚 javadoc 0m 52s the patch passed
+1 💚 shadedjars 4m 32s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 7s hbase-resource-bundle in the patch passed.
+1 💚 unit 0m 42s hbase-http in the patch passed.
-1 ❌ unit 218m 0s /patch-unit-hbase-server.txt hbase-server in the patch failed.
+1 💚 unit 0m 44s hbase-shaded in the patch passed.
+1 💚 unit 0m 16s hbase-assembly in the patch passed.
244m 48s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7614
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0ef29b1f7a78 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5f173ea
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/testReport/
Max. process+thread count 5316 (vs. ulimit of 30000)
modules C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia
Copy link
Contributor Author

The test failures seems unrelated.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@mnpoonia
Copy link
Contributor Author

@stoty thank you for the review. Do you want me to create a separate PR for branch-2. I didnot try cherry-picking this to branch-2 yet.

@stoty
Copy link
Contributor

stoty commented Jan 13, 2026

Yes, let's follow the process and make a backport PR @mnpoonia ,

@mnpoonia
Copy link
Contributor Author

@stoty I tried cherrypicking and it was a clean cherry pick to branch-2 and branch-2.6. Should i still create a separate PR or its not needed.

@stoty
Copy link
Contributor

stoty commented Jan 13, 2026

I would suggest creating a branch-2 PR to make sure that it works with the maven plugins used there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants