Skip to content

HBASE-29820 Bump the syntax of velocity template to align with veloci… #7622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mnpoonia wants to merge 1 commit into
base: branch-2
Choose a base branch
from
Open

HBASE-29820 Bump the syntax of velocity template to align with veloci… #7622

mnpoonia wants to merge 1 commit into from
+54 −54

Conversation

@mnpoonia
Copy link
Contributor

@mnpoonia mnpoonia commented Jan 14, 2026

…ty 2.x syntax

@mnpoonia
Copy link
Contributor Author

mnpoonia commented Jan 14, 2026

@stoty FYI. This is backport for branch-2.x for PR #7614

@Apache-HBase
Copy link

Apache-HBase commented Jan 14, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 18s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 55s branch-2 passed
+1 💚 compile 6m 48s branch-2 passed
+1 💚 spotless 0m 57s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 compile 6m 50s the patch passed
+1 💚 javac 6m 50s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 hadoopcheck 19m 33s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚 spotless 0m 52s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 55s The patch does not generate ASF License warnings.
47m 5s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7622
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname Linux a02199242d50 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d4176f6
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/console
versions git=2.34.1 maven=3.9.8 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 14, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 51s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 29s branch-2 passed
+1 💚 compile 2m 0s branch-2 passed
+1 💚 javadoc 1m 10s branch-2 passed
+1 💚 shadedjars 6m 47s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 3m 8s the patch passed
+1 💚 compile 2m 2s the patch passed
+1 💚 javac 2m 2s the patch passed
+1 💚 javadoc 1m 8s the patch passed
+1 💚 shadedjars 6m 41s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 9s hbase-resource-bundle in the patch passed.
+1 💚 unit 0m 55s hbase-http in the patch passed.
+1 💚 unit 232m 46s hbase-server in the patch passed.
+1 💚 unit 0m 58s hbase-shaded in the patch passed.
+1 💚 unit 0m 29s hbase-assembly in the patch passed.
268m 30s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #7622
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4795efdf7eb8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d4176f6
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/testReport/
Max. process+thread count 3293 (vs. ulimit of 30000)
modules C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty stoty added the backport This PR is a back port of some issue or issues already committed to master label Jan 14, 2026
@Apache-HBase
Copy link

Apache-HBase commented Jan 14, 2026

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 17s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 2s branch-2 passed
+1 💚 compile 1m 49s branch-2 passed
+1 💚 javadoc 1m 9s branch-2 passed
+1 💚 shadedjars 4m 56s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 26s the patch passed
+1 💚 compile 1m 49s the patch passed
+1 💚 javac 1m 49s the patch passed
+1 💚 javadoc 1m 5s the patch passed
+1 💚 shadedjars 5m 3s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 8s hbase-resource-bundle in the patch passed.
+1 💚 unit 0m 42s hbase-http in the patch passed.
-1 ❌ unit 309m 13s /patch-unit-hbase-server.txt hbase-server in the patch failed.
+1 💚 unit 1m 22s hbase-shaded in the patch passed.
+1 💚 unit 0m 25s hbase-assembly in the patch passed.
338m 52s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #7622
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0a5e7144c6d5 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d4176f6
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/testReport/
Max. process+thread count 3316 (vs. ulimit of 30000)
modules C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 14, 2026

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 18s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 23s branch-2 passed
+1 💚 compile 2m 6s branch-2 passed
+1 💚 javadoc 1m 9s branch-2 passed
+1 💚 shadedjars 5m 51s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 2m 59s the patch passed
+1 💚 compile 2m 3s the patch passed
+1 💚 javac 2m 3s the patch passed
+1 💚 javadoc 1m 3s the patch passed
+1 💚 shadedjars 6m 16s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 11s hbase-resource-bundle in the patch passed.
+1 💚 unit 1m 13s hbase-http in the patch passed.
-1 ❌ unit 310m 42s /patch-unit-hbase-server.txt hbase-server in the patch failed.
+1 💚 unit 0m 46s hbase-shaded in the patch passed.
+1 💚 unit 0m 22s hbase-assembly in the patch passed.
343m 57s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7622
Optional Tests javac javadoc unit shadedjars compile
uname Linux 810b674ab87b 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d4176f6
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/testReport/
Max. process+thread count 3475 (vs. ulimit of 30000)
modules C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia
Copy link
Contributor Author

mnpoonia commented Jan 15, 2026

@Apache9 FYI. Another cleanup. Important for updating the dependencies and parent pom.

@stoty
Copy link
Contributor

stoty commented Jan 15, 2026

The unit tests are in a bad shape, but that's not related to these changes.

stoty
stoty approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stoty stoty stoty approved these changes

Assignees

No one assigned

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnpoonia @Apache-HBase @stoty