[GLUTEN-11885][VL] Respect custom VELOX_HOME in build info generation#11905
Open
officialasishkumar wants to merge 1 commit intoapache:mainfrom
Open
[GLUTEN-11885][VL] Respect custom VELOX_HOME in build info generation#11905officialasishkumar wants to merge 1 commit intoapache:mainfrom
officialasishkumar wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Thank you for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #11885.
dev/gluten-build-info.shwas always reading Velox revision metadata from the defaultep/build-velox/build/velox_epcheckout, even when the build used a different Velox source tree via--velox_home.This PR updates the build-info path resolution so the Velox revision metadata is taken from the actual configured Velox checkout:
gluten-build-info.shVELOX_HOMEenvironment variable when presentcpp/build/CMakeCache.txtVELOX_HOMEentry before using the default pathVELOX_HOMEfromdev/builddeps-veloxbe.shso the one-shot Velox build flow propagates the configured path into Maven's build-info generation step--velox_repo,--velox_branch, and--velox_homeas scalars soVELOX_HOMEcan be exported to child processes correctlyHow was this patch tested?
bash -n dev/gluten-build-info.shbash -n dev/builddeps-veloxbe.sh/tmp/fake-veloxVELOX_HOME=/tmp/fake-velox bash dev/gluten-build-info.sh ... --backend veloxwrites the fake repo commit intogluten-build-info.propertiessource ./dev/builddeps-veloxbe.sh --velox_home=/tmp/fake-velox trueexportsVELOX_HOMEfor child processesWas this patch authored or co-authored using generative AI tooling?
No