[GLUTEN-11885][VL] Respect custom Velox home in build info generation#11903
Open
officialasishkumar wants to merge 1 commit intoapache:mainfrom
Open
[GLUTEN-11885][VL] Respect custom Velox home in build info generation#11903officialasishkumar wants to merge 1 commit intoapache:mainfrom
officialasishkumar wants to merge 1 commit intoapache:mainfrom
Conversation
Make gluten-build-info.sh resolve the Velox checkout from explicit overrides, the VELOX_HOME environment variable, and cpp/build/CMakeCache.txt before falling back to the hardcoded default path. The script now parses all arguments before writing the properties file so backend-home overrides are order-independent.
Contributor
|
duplicated with #11905? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #11885.
dev/gluten-build-info.shwas hardcoding the Velox checkout path when writing build metadata, so builds done against a custom Velox source tree still reported the default bundled path.This change makes the script resolve the Velox checkout in the following order:
--backend_home/--velox_homeoverrideVELOX_HOMEVELOX_HOMErecorded incpp/build/CMakeCache.txtThe script now also parses arguments before writing the properties file so backend-home overrides are order-independent.
How was this patch tested?
bash -n dev/gluten-build-info.sh--backend_homeVELOX_HOMEenvironment fallbackcpp/build/CMakeCache.txtfallbackWas this patch authored or co-authored using generative AI tooling?
No