Skip to content

fix: remove redundant Python assignments #19829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankChen021 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

fix: remove redundant Python assignments #19829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions distribution/bin/jar-notice-lister.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ def get_notices(tmp_jar_path):
for line in outstr.splitlines():
try:
command = "jar xf {} {}".format(jar_file, line)
outstr = subprocess.check_output(command, shell=True).decode('UTF-8')
subprocess.check_output(command, shell=True)

command = "mv {} {}.NOTICE-FILE".format(line, jar_file)
outstr = subprocess.check_output(command, shell=True).decode('UTF-8')
subprocess.check_output(command, shell=True)

command = "cat {}.NOTICE-FILE".format(jar_file)
outstr = subprocess.check_output(command, shell=True).decode('UTF-8')
Expand All @@ -95,4 +95,4 @@ def get_notices(tmp_jar_path):
try:
main()
except KeyboardInterrupt:
print('Interrupted, closing.')
print('Interrupted, closing.')
2 changes: 1 addition & 1 deletion examples/bin/start-druid-main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ def distribute_memory(services, total_memory):
if service in MINIMUM_MEMORY_MB and allocated_memory < MINIMUM_MEMORY_MB.get(service):
allocated_memory = MINIMUM_MEMORY_MB.get(service)

service_memory_config[service], allocated_memory = build_memory_config(service, allocated_memory)
service_memory_config[service] = build_memory_config(service, allocated_memory)[0]

print_if_verbose('\nMemory distribution for services:')
for key, value in service_memory_config.items():
Expand Down
Loading