Skip to content

fix: remove redundant Python assignments - #19829

Open
FrankChen021 wants to merge 1 commit into
apache:masterfrom
FrankChen021:codex/codeql-warning-python-definitions
Open

fix: remove redundant Python assignments#19829
FrankChen021 wants to merge 1 commit into
apache:masterfrom
FrankChen021:codex/codeql-warning-python-definitions

Conversation

@FrankChen021

Copy link
Copy Markdown
Member

Created by GPT-5.6-Sol.

Summary

  • keep only the memory configuration returned for services whose adjusted allocation is not reused
  • discard the intentionally unused output of jar extraction and move commands instead of repeatedly redefining the NOTICE output variable
  • add the required trailing newline to the NOTICE helper

This directly addresses all three py/multiple-definition CodeQL warnings without changing command execution or output behavior.

Validation

  • both modified scripts compile with Python 3 py_compile
  • git diff --check passed

@FrankChen021
FrankChen021 marked this pull request as ready for review July 30, 2026 18:25
Copilot AI review requested due to automatic review settings July 30, 2026 18:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@FrankChen021
FrankChen021 requested a review from Copilot July 30, 2026 22:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.

Reviewed 2 of 2 changed files.


This is an automated review by Codex GPT-5.6-Sol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants