chore(parquet): remove deprecated schema-coercion helpers (Closes #23080 - partial)#23132
Merged
alamb merged 3 commits intoJun 23, 2026
Merged
Conversation
… `coerce_file_schema_to_string_type` Both free functions were deprecated in DataFusion 47.0.0 with the suggestion to use `apply_file_schema_type_coercions` instead. Per the API health deprecation guidelines, APIs deprecated in 47.0.0 are eligible for removal now that datafusion is on 55.x. A repo-wide grep confirms zero callers of either function — the only references are the function definitions themselves and two historical `pub use` re-export entries in `mod.rs` and `file_format.rs`, which are removed in this commit. The replacement `apply_file_schema_type_coercions` is in active use at `metadata.rs:403` and `opener/mod.rs:960`. The `#[expect(deprecated)]` attribute on the re-export lines is no longer needed once the deprecated symbols are gone. Closes apache#23080 (partial).
alamb
approved these changes
Jun 23, 2026
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you (again) @Dodothereal
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Contributor
|
I took the liberty of merging up from main and fixing the clippy error and pushing to your branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes coerce_file_schema_to_view_type and coerce_file_schema_to_string_type (both deprecated since 47.0.0 with replacement apply_file_schema_type_coercions). Zero callers in the workspace; only the function definitions and re-export entries in mod.rs / file_format.rs remain. Drops the now-unused #[expect(deprecated)] attribute on the re-export lines. Pure 118-line deletion across 3 files. Part of #23080 (partial - third in the housekeeping series after #23129 and #23131). AI assistance: used an AI coding assistant to identify and remove unused symbols; verified via repo-wide grep that the deprecated functions have no callers.