chore(expr-common): remove deprecated Signature get_possible_types (Closes #23080 - partial)#23135
Open
Dodothereal wants to merge 1 commit into
Open
Conversation
`Signature::get_possible_types` was deprecated in DataFusion 46.0.0 with the suggestion to use `get_example_types` instead. Per the API health deprecation guidelines, APIs deprecated in 46.0.0 are eligible for removal now that datafusion is on 55.x. The in-tree test `test_get_possible_types` already calls `get_example_types` directly, so no test changes are needed. Repo-wide grep confirms there are no other callers — the function was a one-line adapter to `get_example_types`. Pure 5-line deletion. Closes apache#23080 (partial — fifth in the housekeeping series after apache#23129, apache#23131, apache#23132, apache#23134).
Contributor
Author
Contributor
Author
|
@alamb (and any other reviewer) — gentle ping: this is the 5th and last non-experimental removal in the #23080 sweep; the first three (#23129, #23131, #23132) landed today, #23134 was just opened for the 4th. Branch is up to date with upstream/main; |
This was referenced Jun 23, 2026
Contributor
Author
|
Friendly nudge — same pattern as #23134 (5-line pure-removal, zero callers). Ready when a maintainer can approve CI / merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Signature::get_possible_types (deprecated since 46.0.0 with replacement get_example_types). Pure 5-line deletion; the in-tree unit test already calls get_example_types directly, so no test updates needed. Closes #23080 (partial - fifth in housekeeping series after #23129, #23131, #23132, #23134). AI assistance: used an AI coding assistant; verified via repo-wide grep that the function is unused outside tests.