Skip to content

Used constant with mapping instead of write! to display scalar value bytes #20719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buraksenn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Used constant with mapping instead of write! to display scalar value bytes #20719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion datafusion/common/src/scalar/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ use std::cmp::Ordering;
use std::collections::{HashSet, VecDeque};
use std::convert::Infallible;
use std::fmt;
use std::fmt::Write;
use std::hash::Hash;
use std::hash::Hasher;
use std::iter::repeat_n;
Expand Down Expand Up @@ -4959,8 +4960,10 @@ impl fmt::Display for ScalarValue {
| ScalarValue::BinaryView(e) => match e {
Some(bytes) => {
// print up to first 10 bytes, with trailing ... if needed
const HEX_CHARS_UPPER: &[u8; 16] = b"0123456789ABCDEF";
for b in bytes.iter().take(10) {
write!(f, "{b:02X}")?;
f.write_char(HEX_CHARS_UPPER[(b >> 4) as usize] as char)?;
f.write_char(HEX_CHARS_UPPER[(b & 0x0f) as usize] as char)?;
}
if bytes.len() > 10 {
write!(f, "...")?;
Expand Down