Used constant with mapping instead of write! to display scalar value bytes #20719
Open
buraksenn wants to merge 1 commit intoapache:mainfrom
Open
Used constant with mapping instead of write! to display scalar value bytes #20719buraksenn wants to merge 1 commit intoapache:mainfrom
buraksenn wants to merge 1 commit intoapache:mainfrom
Conversation
alamb
approved these changes
Mar 5, 2026
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @buraksenn
I confirmed that this appears to be the last usage
https://github.com/search?q=repo%3Aapache%2Fdatafusion%20%7Bb%3A02X%7D&type=code
FYI @andygrove as you filed the original request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
"{b:02x}"to hex-encode bytes #19569.Rationale for this change
This was the latest usage as far as I can see so I've changed it. I think this is not on the hot path so if you want we can close the PR and issue with it.
What changes are included in this PR?
Instead of using write! format string write hex with using constant char mapping
Are these changes tested?
Runned debug display tests:
Are there any user-facing changes?
No