Conversation
manuzhang
force-pushed
the
test-array-cast
branch
4 times, most recently
from
864a25f to
92a7867
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2897 +/- ##
============================================
+ Coverage 56.12% 59.53% +3.40%
- Complexity 976 1376 +400
============================================
Files 119 167 +48
Lines 11743 15496 +3753
Branches 2251 2569 +318
============================================
+ Hits 6591 9225 +2634
- Misses 4012 4971 +959
- Partials 1140 1300 +160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Created #2914 for the failed test |
|
Submitted #2916 to fix the failed test. |
manuzhang
force-pushed
the
test-array-cast
branch
from
92a7867 to
5f7b017
Compare
| Ok(cast_with_options(&array, to_type, &CAST_OPTIONS)?) | ||
| (List(from), List(to)) | ||
| if can_cast_types(from_type, to_type) | ||
| || (matches!(from.data_type(), Decimal128(_, _)) |
There was a problem hiding this comment.
Is this the only case where we have a spark cast but no DF/arrow cast?
| } | ||
|
|
||
| private def generateArrays(rowSize: Int, elementType: DataType): DataFrame = { | ||
| private def generateArrays(rowNum: Int, elementType: DataType): DataFrame = { |
There was a problem hiding this comment.
nit : might be an unintended change ?
There was a problem hiding this comment.
This is intended since rowNum (meaning the number of rows) makes more sense to me.
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
manuzhang
force-pushed
the
test-array-cast
branch
from
5f7b017 to
9c99e19
Compare
manuzhang
force-pushed
the
test-array-cast
branch
2 times, most recently
from
d9770c7 to
fae74f6
Compare
|
Taking a look |
|
@coderfender Sorry, there are more test failures that I need to fix first. |
manuzhang
force-pushed
the
test-array-cast
branch
2 times, most recently
from
f0455fd to
b93600c
Compare
manuzhang
force-pushed
the
test-array-cast
branch
from
b93600c to
b73aff5
Compare
|
@coderfender It's ready for review now. |
4 participants
Which issue does this PR close?
Part of #2766
Rationale for this change
What changes are included in this PR?
How are these changes tested?
Added tests.