fix: native error message not propagated to SparkException on empty errorClass#3727
Open
manuzhang wants to merge 1 commit intoapache:mainfrom
Open
fix: native error message not propagated to SparkException on empty errorClass#3727manuzhang wants to merge 1 commit intoapache:mainfrom
manuzhang wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@parthchandra Please help review when you are free. |
Contributor
|
The original issue references a test failing, are we passing that now? Do we need to make any changes to the test (are we skipping it?) |
Member
Author
|
@mbutrovich The failure was from previous commit of #2897, not on the main branch. |
parthchandra
approved these changes
Mar 18, 2026
Contributor
parthchandra
left a comment
parthchandra
left a comment
There was a problem hiding this comment.
This change is fine. It would be good to know what the root cause of the failure was and to ensure that the error is actually handled correctly in native.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3726.