Skip to content

Fix template-field logic timing in BashOperator#70437

Open
bramhanandlingala wants to merge 1 commit into
apache:mainfrom
bramhanandlingala:fix/70296-4
Open

Fix template-field logic timing in BashOperator#70437
bramhanandlingala wants to merge 1 commit into
apache:mainfrom
bramhanandlingala:fix/70296-4

Conversation

@bramhanandlingala

Copy link
Copy Markdown
Contributor

Fixes the standard provider's BashOperator entry from the #70296 exemption-list burn-down.

bash_command is a template field, but __init__ classified it as inline-vs-script-file using the raw, un-rendered string — so a templated value could be misclassified before Jinja ever rendered it.

  • Moved the classification into execute(), after templating occurs.
  • __init__ no longer touches bash_command's content.
  • Removed BashOperator from the exemption list.
  • Added a test covering a templated bash_command resolving to a script file.

Related to #70296

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I've somehow missed it in #70315 that I've already merged - but it should be clarified:

You must disclose AI usage in the code changes within the PR body according to the guidelines.
I'd like to ask editing the PR body of both your merged PRs ( #68342,
#70315), as well as all of your open PRs to add AI attribution with the PR body - otherwise they will be blocked from merging.
Once this is addressed, I will remove the block. Please do not create new PRs that are gen-AI assisted without disclosure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants