Skip to content

Fix template-field validation timing in PapermillOperator#70435

Open
bramhanandlingala wants to merge 1 commit into
apache:mainfrom
bramhanandlingala:fix/70296-3
Open

Fix template-field validation timing in PapermillOperator#70435
bramhanandlingala wants to merge 1 commit into
apache:mainfrom
bramhanandlingala:fix/70296-3

Conversation

@bramhanandlingala

Copy link
Copy Markdown
Contributor

Fixes the papermill provider's entry from the #70296 exemption-list burn-down: PapermillOperator.

input_nb and output_nb are template fields, but were validated in __init__ — before Jinja templating runs, so the check ran against the raw un-rendered value.

  • Moved validation from __init__ to execute(), after templating occurs.
  • __init__ now only does plain assignments.
  • Removed PapermillOperator from the exemption list.
  • Updated existing test + added a new test covering the fixed behavior.

Related to #70296

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants