Skip to content

fix(tui): resolve keyboard deadlock in question mode #36550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maharshi365 wants to merge 2 commits into
base: dev
Choose a base branch
from
+19 −5
Open

fix(tui): resolve keyboard deadlock in question mode #36550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6e87a4
fix(tui): resolve keyboard deadlock in question mode
maharshi365 Jul 12, 2026
45a2534
Merge branch 'dev' into fix-question-keyboard-deadlock
maharshi365 Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/tui/src/routes/session/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,11 +1286,13 @@ export function Session() {
directory={sync.session.get(permissions()[0].sessionID)?.directory}
/>
</Show>
<Show when={permissions().length === 0 && questions().length > 0}>
<QuestionPrompt
request={questions()[0]}
directory={sync.session.get(questions()[0].sessionID)?.directory}
/>
<Show when={permissions().length === 0 ? questions()[0] : undefined} keyed>
{(request) => (
<QuestionPrompt
request={request}
directory={sync.session.get(request.sessionID)?.directory}
/>
)}
</Show>
<Show when={session()?.parentID}>
<SubagentFooter />
Expand Down
12 changes: 12 additions & 0 deletions packages/tui/src/routes/session/question.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ export function QuestionPrompt(props: { request: QuestionRequest; directory?: st
function selectTab(index: number) {
setStore("tab", index)
setStore("selected", 0)
setStore("editing", false)
}

function selectOption() {
Expand Down Expand Up @@ -133,6 +134,7 @@ export function QuestionPrompt(props: { request: QuestionRequest; directory?: st
useBindings(() => ({
mode: QUESTION_MODE,
enabled: store.editing && !confirm(),
priority: 1,
commands: [
{
name: "prompt.clear",
Expand All @@ -147,6 +149,14 @@ export function QuestionPrompt(props: { request: QuestionRequest; directory?: st
textarea?.setText("")
},
},
{
name: "app.exit",
title: "Reject question",
category: "Question",
run() {
reject()
},
},
],
bindings: [
{
Expand All @@ -158,6 +168,7 @@ export function QuestionPrompt(props: { request: QuestionRequest; directory?: st
},
},
...tuiConfig.keybinds.get("prompt.clear"),
...tuiConfig.keybinds.get("app.exit"),
{
key: "return",
desc: "Submit answer edit",
Expand Down Expand Up @@ -214,6 +225,7 @@ export function QuestionPrompt(props: { request: QuestionRequest; directory?: st
return {
mode: QUESTION_MODE,
enabled: !store.editing,
priority: 1,
commands: [
{
name: "app.exit",
Expand Down
Loading