fix(tui): resolve keyboard deadlock in question mode#36550
Open
maharshi365 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36382
Closes #30517
Type of change
What does this PR do?
The
QuestionPromptcomponent has twouseBindingscalls with mutually exclusiveenabledconditions:enabled: store.editing && !confirm()enabled: !store.editingWhen a user starts typing a custom answer (
store.editing = true) and then clicks the Confirm tab with the mouse (confirm() = true), both binding sets become disabled simultaneously. This causes a full keyboard lockout — Enter, Escape, Ctrl+C, and all shortcuts stop responding. Mouse events still work because they bypass the keymap system.The fix:
editingon tab change —selectTab()now setsediting = false, preventing the deadlock state from being reachable.priority: 1to both binding sets so they take precedence over the globalmanagedTextareaLayer(which can intercept Enter when a textarea has focus).app.exitto editing mode bindings so Ctrl+C works while typing a custom answer.QuestionPromptby request using<Show keyed>so stale internal state doesn't persist across different question requests.How did you verify your code works?
Reproduced the deadlock locally by entering "Type your own answer" editing mode then clicking the Confirm tab. Verified that after the fix, keyboard remains responsive in all tab/editing combinations. Typecheck passes (
bun typecheckfrompackages/tui).Screenshots / recordings
N/A — keyboard input fix, no visual change.
Checklist