Skip to content

fix(renovate-presets): group undici and undici-types packages #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 wants to merge 1 commit into from
Closed

fix(renovate-presets): group undici and undici-types packages #3605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions renovate-presets/default.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@
// GENERAL GROUPING & UPDATE BEHAVIOR
// ============================================================================

// Group undici packages together. This is to avoid a situation where undici
// is updated and the types are not updated, causing type errors.
{
groupName: 'undici',
matchManagers: ['npm'],
matchDepNames: ['undici', 'undici-types'],
},
Comment on lines +45 to +51
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Logic Error: Rule Placement

The current placement of this rule at the beginning of packageRules causes it to be overridden by the all non-major dependencies rule (lines 86-93) for any non-major updates.

If undici has a major update and undici-types has a minor update, they will be split into separate Pull Requests, which defeats the purpose of this change. To fix this, move this block after the all non-major dependencies rule (around line 94).

Consistency: Group Naming

To match the naming convention used for other dependency groups in this file (e.g., jasmine dependencies, typescript dependencies), please rename the group to undici dependencies.

    // Group undici packages together. This is to avoid a situation where undici
    // is updated and the types are not updated, causing type errors.
    {
      groupName: 'undici dependencies',
      matchManagers: ['npm'],
      matchDepNames: ['undici', 'undici-types'],
    },


// Enable 'postUpdateTasks' for changes that effect the typescript and pnpm versions.
// This is to ensure that the `MODULE.bazel` is updated with the correct versions.
{
Expand Down
Loading