Skip to content

fix(renovate-presets): group undici and undici-types packages#3605

Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:group-undici
Closed

fix(renovate-presets): group undici and undici-types packages#3605
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:group-undici

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

Groups undici and undici-types together to prevent type errors when only one of them is updated.

Groups undici and undici-types together to prevent type errors when only one of them is updated.
@alan-agius4 alan-agius4 requested a review from devversion April 15, 2026 08:35
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 15, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a Renovate package rule to group 'undici' and 'undici-types' together, ensuring they are updated simultaneously to avoid type errors. The review feedback points out a logic error where the rule's placement might cause it to be overridden by broader dependency rules and suggests renaming the group for consistency with existing naming conventions.

Comment on lines +45 to +51
// Group undici packages together. This is to avoid a situation where undici
// is updated and the types are not updated, causing type errors.
{
groupName: 'undici',
matchManagers: ['npm'],
matchDepNames: ['undici', 'undici-types'],
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Logic Error: Rule Placement

The current placement of this rule at the beginning of packageRules causes it to be overridden by the all non-major dependencies rule (lines 86-93) for any non-major updates.

If undici has a major update and undici-types has a minor update, they will be split into separate Pull Requests, which defeats the purpose of this change. To fix this, move this block after the all non-major dependencies rule (around line 94).

Consistency: Group Naming

To match the naming convention used for other dependency groups in this file (e.g., jasmine dependencies, typescript dependencies), please rename the group to undici dependencies.

    // Group undici packages together. This is to avoid a situation where undici
    // is updated and the types are not updated, causing type errors.
    {
      groupName: 'undici dependencies',
      matchManagers: ['npm'],
      matchDepNames: ['undici', 'undici-types'],
    },

@alan-agius4 alan-agius4 deleted the group-undici branch April 15, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant