fix(renovate-presets): group undici and undici-types packages#3605
fix(renovate-presets): group undici and undici-types packages#3605alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
Groups undici and undici-types together to prevent type errors when only one of them is updated.
There was a problem hiding this comment.
Code Review
This pull request adds a Renovate package rule to group 'undici' and 'undici-types' together, ensuring they are updated simultaneously to avoid type errors. The review feedback points out a logic error where the rule's placement might cause it to be overridden by broader dependency rules and suggests renaming the group for consistency with existing naming conventions.
| // Group undici packages together. This is to avoid a situation where undici | ||
| // is updated and the types are not updated, causing type errors. | ||
| { | ||
| groupName: 'undici', | ||
| matchManagers: ['npm'], | ||
| matchDepNames: ['undici', 'undici-types'], | ||
| }, |
There was a problem hiding this comment.
Logic Error: Rule Placement
The current placement of this rule at the beginning of packageRules causes it to be overridden by the all non-major dependencies rule (lines 86-93) for any non-major updates.
If undici has a major update and undici-types has a minor update, they will be split into separate Pull Requests, which defeats the purpose of this change. To fix this, move this block after the all non-major dependencies rule (around line 94).
Consistency: Group Naming
To match the naming convention used for other dependency groups in this file (e.g., jasmine dependencies, typescript dependencies), please rename the group to undici dependencies.
// Group undici packages together. This is to avoid a situation where undici
// is updated and the types are not updated, causing type errors.
{
groupName: 'undici dependencies',
matchManagers: ['npm'],
matchDepNames: ['undici', 'undici-types'],
},
Groups undici and undici-types together to prevent type errors when only one of them is updated.