Skip to content

docs(aria/combobox): bind cdkConnectedOverlayOpen to popupExpanded in simple-combobox examples#33197

Merged
tjshiu merged 1 commit intoangular:mainfrom
tjshiu:popupExpanded
May 4, 2026
Merged

docs(aria/combobox): bind cdkConnectedOverlayOpen to popupExpanded in simple-combobox examples#33197
tjshiu merged 1 commit intoangular:mainfrom
tjshiu:popupExpanded

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented May 4, 2026

Updates all SimpleCombobox component examples to bind the overlay's cdkConnectedOverlayOpen property directly to the reactive popupExpanded signal.

Fixes #32678

… simple-combobox examples

Updates all `SimpleCombobox` component examples to bind the overlay's
`cdkConnectedOverlayOpen` property directly to the reactive `popupExpanded` signal.

Fixes angular#32678
@pullapprove pullapprove Bot requested review from crisbeto and ok7sai May 4, 2026 19:03
@angular-robot angular-robot Bot added area: docs Related to the documentation area: aria/combobox labels May 4, 2026
@tjshiu tjshiu added target: major This PR is targeted for the next major release dev-app preview When applied, previews of the dev-app are deployed to Firebase area: docs Related to the documentation area: aria/combobox and removed area: docs Related to the documentation area: aria/combobox labels May 4, 2026
Copy link
Copy Markdown
Member

@ok7sai ok7sai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I thought this breaks the binding between the ngCombobox and ngComboboxPopup.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Deployed dev-app for a973431 to: https://ng-dev-previews-comp--pr-angular-components-33197-dev-e4rsmkpz.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@tjshiu tjshiu added the action: merge The PR is ready for merge by the caretaker label May 4, 2026
@tjshiu tjshiu merged commit d396fa8 into angular:main May 4, 2026
43 checks passed
@tjshiu
Copy link
Copy Markdown
Contributor Author

tjshiu commented May 4, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@tjshiu tjshiu deleted the popupExpanded branch May 4, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: aria/combobox area: docs Related to the documentation dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(aria): Combobox and Menu should using CDK overlay with the same approach

2 participants