Skip to content

Commit d396fa8

Browse files
authored
docs(aria/combobox): bind cdkConnectedOverlayOpen to popupExpanded in simple-combobox examples (#33197)
Updates all `SimpleCombobox` component examples to bind the overlay's `cdkConnectedOverlayOpen` property directly to the reactive `popupExpanded` signal. Fixes #32678
1 parent e3d84f2 commit d396fa8

14 files changed

Lines changed: 14 additions & 14 deletions

File tree

src/components-examples/aria/aria-toolbar-simple-combobox/simple-toolbar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export class SimpleToolbarRadioButton {
8282
>
8383
</div>
8484
85-
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
85+
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="popupExpanded()"
8686
[cdkConnectedOverlayDisableClose]="true">
8787
<ng-template ngComboboxPopup [combobox]="combobox">
8888
<div ngListbox ngComboboxWidget [(value)]="selectedOption" class="example-listbox example-popup" focusMode="activedescendant"

src/components-examples/aria/simple-combobox/simple-combobox-auto-select/simple-combobox-auto-select-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
{{options().length === 0 ? 'No results found for ' + searchString() : ''}}
1010
</div>
1111

12-
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
12+
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="popupExpanded()"
1313
[cdkConnectedOverlayDisableClose]="true">
1414
<ng-template ngComboboxPopup [combobox]="combobox">
1515
<div class="example-popup">

src/components-examples/aria/simple-combobox/simple-combobox-autocomplete-auto-select/simple-combobox-autocomplete-auto-select-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
{{countries().length === 0 ? 'No results found for ' + query() : ''}}
2525
</div>
2626

27-
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true">
27+
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="popupExpanded()">
2828
<ng-template ngComboboxPopup [combobox]="combobox">
2929
<div class="example-popup">
3030
@if (countries().length === 0) {

src/components-examples/aria/simple-combobox/simple-combobox-autocomplete-disabled/simple-combobox-autocomplete-disabled-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
/>
1414
</div>
1515

16-
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true">
16+
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="popupExpanded()">
1717
<ng-template ngComboboxPopup [combobox]="combobox">
1818
<div class="example-popup">
1919
@if (countries().length === 0) {

src/components-examples/aria/simple-combobox/simple-combobox-autocomplete-highlight/simple-combobox-autocomplete-highlight-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
</div>
1616

1717
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}"
18-
[cdkConnectedOverlayOpen]="true">
18+
[cdkConnectedOverlayOpen]="popupExpanded()">
1919
<ng-template ngComboboxPopup [combobox]="combobox">
2020
<div class="example-popup">
2121
@if (countries().length === 0) {

src/components-examples/aria/simple-combobox/simple-combobox-autocomplete-manual/simple-combobox-autocomplete-manual-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
</div>
1414

1515
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}"
16-
[cdkConnectedOverlayOpen]="true">
16+
[cdkConnectedOverlayOpen]="popupExpanded()">
1717
<ng-template ngComboboxPopup [combobox]="combobox">
1818
<div class="example-popup">
1919
@if (countries().length === 0) {

src/components-examples/aria/simple-combobox/simple-combobox-grid/simple-combobox-grid-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
{{filteredItems().length === 0 ? 'No results found for ' + searchString() : ''}}
1010
</div>
1111

12-
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
12+
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="popupExpanded()"
1313
[cdkConnectedOverlayDisableClose]="true">
1414
<ng-template ngComboboxPopup [combobox]="combobox">
1515
<div class="example-popup">

src/components-examples/aria/simple-combobox/simple-combobox-highlight/simple-combobox-highlight-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
{{options().length === 0 ? 'No results found for ' + searchString() : ''}}
1212
</div>
1313

14-
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
14+
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="popupExpanded()"
1515
[cdkConnectedOverlayDisableClose]="true">
1616
<ng-template ngComboboxPopup [combobox]="combobox">
1717
<div class="example-popup">

src/components-examples/aria/simple-combobox/simple-combobox-listbox/simple-combobox-listbox-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
{{options().length === 0 ? 'No results found for ' + searchString() : ''}}
1010
</div>
1111

12-
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
12+
<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="popupExpanded()"
1313
[cdkConnectedOverlayDisableClose]="true">
1414
<ng-template ngComboboxPopup [combobox]="combobox">
1515
<div class="example-popup">

src/components-examples/aria/simple-combobox/simple-combobox-readonly-disabled/simple-combobox-readonly-disabled-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
</div>
55

66
<ng-template [cdkConnectedOverlay]="{origin: combobox.element, usePopover: 'inline', matchWidth: true}"
7-
[cdkConnectedOverlayOpen]="true" [cdkConnectedOverlayDisableClose]="true">
7+
[cdkConnectedOverlayOpen]="popupExpanded()" [cdkConnectedOverlayDisableClose]="true">
88
<ng-template ngComboboxPopup [combobox]="combobox">
99
<div class="example-popup-container">
1010
<div #listbox="ngListbox" ngListbox tabindex="-1" ngComboboxWidget focusMode="activedescendant"

0 commit comments

Comments
 (0)