DO NOT MERGE: test dual-condition monitor with cache-only memory pressure#970
Draft
devin-ai-integration[bot] wants to merge 2 commits intodevin/1774478445-memory-failfastfrom
Draft
Conversation
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1774888310-memory-failfast-feature-2#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1774888310-memory-failfast-feature-2PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
…-condition monitor Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
4 tasks
Contributor
|
/prerelease
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets the following PR:
Summary
Adds a synthetic cache memory pressure scenario in
AirbyteEntrypoint.read()to test the negative case of the dual-condition memory monitor (introduced in #962). For each consumed record, a 10 MB file-backed shared mmap page is created on/dev/shm, which inflates cgroup memory usage without increasing the Python process's anonymous RSS (RssAnon).This validates that the memory monitor correctly does not raise
AirbyteTracedExceptionwhen container memory is high but the pressure comes from file-backed/shared pages rather than process-private anonymous memory.DO NOT MERGE — test-only change to validate memory monitor behavior.
Companion PR: #969 (tests the positive case — process RSS growth triggers fail-fast)
Review & Testing Checklist for Human
RssAnonin/proc/self/statusremains low relative to the container limitAirbyteTracedExceptionshutdownNotes
tempfile.mktemp(which has a theoretical race condition) rather thantempfile.mkstemp; acceptable for a throwaway test branch/dev/shm; memory growth rate depends on record throughputLink to Devin session: https://app.devin.ai/sessions/070ecb51ceee4f9189e1c09a83ba31cb