DO NOT MERGE: test graceful OOM shutdown via intentional memory leak#969
Open
devin-ai-integration[bot] wants to merge 2 commits intodevin/1774478445-memory-failfastfrom
Open
Conversation
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1774888252-memory-failfast-feature-1#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1774888252-memory-failfast-feature-1PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
5 tasks
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
Contributor
|
/prerelease
|
Draft
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets the following PR:
Summary
Adds an intentional memory leak in
AirbyteEntrypoint.read()to test the memory monitor's graceful shutdown behavior (introduced in #962). Each consumed record is duplicated 500× into a growing list to rapidly inflate Python process anonymous RSS, which should trigger the dual-condition fail-fast check.This tests the positive case: the memory monitor should detect and raise
AirbyteTracedExceptionwhen both cgroup usage and process anonymous RSS exceed their respective thresholds.DO NOT MERGE — test-only change to validate memory monitor behavior.
Companion PR: #970 (tests the negative case — cgroup pressure without process RSS growth)
Review & Testing Checklist for Human
AirbyteTracedExceptionat ~98% cgroup + ~90% RssAnonNotes
devin/1774478445-memory-failfast; the other (DO NOT MERGE: test dual-condition monitor with cache-only memory pressure #970) tests that non-process memory pressure does not trigger fail-fastLink to Devin session: https://app.devin.ai/sessions/070ecb51ceee4f9189e1c09a83ba31cb