Skip to content

fix(ci): resolve SonarQube security issues in workflows and Dockerfile #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olivermeyer merged 2 commits into from
May 6, 2026
Merged

fix(ci): resolve SonarQube security issues in workflows and Dockerfile #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2558bdf
fix(docker): add --no-build to uv sync --no-install-project stages
olivermeyer May 5, 2026
12dd307
fix(ci): add --frozen to uv run commands in CI workflows
olivermeyer May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/_claude-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
if: ${{ !startsWith(github.ref, 'refs/tags/v') }}
shell: bash
run: |
TOML_VERSION=$(uv run python -c "import tomli; print(tomli.load(open('pyproject.toml', 'rb'))['project']['version'])")
TOML_VERSION=$(uv run --frozen python -c "import tomli; print(tomli.load(open('pyproject.toml', 'rb'))['project']['version'])")
echo "Development build - Current version in pyproject.toml: $TOML_VERSION"

- name: Run Claude Code (Interactive Mode)
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/_package-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Validate installation
shell: bash
run: |
OUTPUT=$(uv run --all-extras --no-dev aignostics --help)
OUTPUT=$(uv run --frozen --all-extras --no-dev aignostics --help)
if [[ "$OUTPUT" != *"built with love in Berlin"* ]]; then
echo "Output does not contain 'built with love in Berlin'"
exit 1
Expand Down Expand Up @@ -149,7 +149,7 @@ jobs:
- name: Final smoke test
shell: bash
run: |
uv run --no-dev aignostics --help
uv run --frozen --no-dev aignostics --help

- name: Docs
shell: bash
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/_scheduled-test-daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
if: ${{ !startsWith(github.ref, 'refs/tags/v') }}
shell: bash
run: |
TOML_VERSION=$(uv run python -c "import tomli; print(tomli.load(open('pyproject.toml', 'rb'))['project']['version'])")
TOML_VERSION=$(uv run --frozen python -c "import tomli; print(tomli.load(open('pyproject.toml', 'rb'))['project']['version'])")
echo "Development build - Current version in pyproject.toml: $TOML_VERSION"

- name: Create .env file
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
continue-on-error: true
shell: bash
run: |
OUTPUT=$(uv run --no-dev aignostics --help)
OUTPUT=$(uv run --frozen --no-dev aignostics --help)
if [[ "$OUTPUT" != *"built with love in Berlin"* ]]; then
echo "Output does not contain 'built with love in Berlin'"
exit 1
Expand All @@ -119,12 +119,12 @@ jobs:
continue-on-error: true
shell: bash
run: |
uv run --no-dev aignostics --help
uv run --all-extras aignostics system info
uv run --all-extras aignostics system health
uv run --all-extras aignostics user whoami --mask-secrets
uv run --all-extras aignostics application list
uv run --all-extras aignostics application run list --verbose --limit 1
uv run --frozen --no-dev aignostics --help
uv run --frozen --all-extras aignostics system info
uv run --frozen --all-extras aignostics system health
uv run --frozen --all-extras aignostics user whoami --mask-secrets
uv run --frozen --all-extras aignostics application list
uv run --frozen --all-extras aignostics application run list --verbose --limit 1

- name: Test / Unit (multiple Python versions)
id: unit
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
shell: bash
run: |
TAG_VERSION=${GITHUB_REF#refs/tags/v}
TOML_VERSION=$(uv run python -c "import tomli; print(tomli.load(open('pyproject.toml', 'rb'))['project']['version'])")
TOML_VERSION=$(uv run --frozen python -c "import tomli; print(tomli.load(open('pyproject.toml', 'rb'))['project']['version'])")
if [ "$TAG_VERSION" != "$TOML_VERSION" ]; then
echo "Release version mismatch: Tag $TAG_VERSION != pyproject.toml $TOML_VERSION"
exit 1
Expand All @@ -110,7 +110,7 @@ jobs:
if: ${{ !startsWith(github.ref, 'refs/tags/v') }}
shell: bash
run: |
TOML_VERSION=$(uv run python -c "import tomli; print(tomli.load(open('pyproject.toml', 'rb'))['project']['version'])")
TOML_VERSION=$(uv run --frozen python -c "import tomli; print(tomli.load(open('pyproject.toml', 'rb'))['project']['version'])")
echo "Development build - Current version in pyproject.toml: $TOML_VERSION"

- name: Create .env file
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
- name: Validate installation (single Python version)
shell: bash
run: |
OUTPUT=$(uv run --no-dev aignostics --help)
OUTPUT=$(uv run --frozen --no-dev aignostics --help)
if [[ "$OUTPUT" != *"built with love in Berlin"* ]]; then
echo "Output does not contain 'built with love in Berlin'"
exit 1
Expand All @@ -149,12 +149,12 @@ jobs:
- name: Test / Smoke (single Python version)
shell: bash
run: |
uv run --no-dev aignostics --help
uv run --all-extras aignostics system info
uv run --all-extras aignostics system health
uv run --all-extras aignostics user whoami --mask-secrets
uv run --all-extras aignostics application list
uv run --all-extras aignostics application run list --verbose --limit 1
uv run --frozen --no-dev aignostics --help
uv run --frozen --all-extras aignostics system info
uv run --frozen --all-extras aignostics system health
uv run --frozen --all-extras aignostics user whoami --mask-secrets
uv run --frozen --all-extras aignostics application list
uv run --frozen --all-extras aignostics application run list --verbose --limit 1

# All test steps use continue-on-error: true so that every test suite
# always runs regardless of whether earlier suites failed. This ensures
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ jobs:
PREV_TAG="${{ steps.version.outputs.prev_tag }}"
TAG_NAME="${{ steps.version.outputs.tag_name }}"
if [ -n "$PREV_TAG" ]; then
uv run git-cliff --tag "$TAG_NAME" --prepend CHANGELOG.md "${PREV_TAG}..HEAD"
uv run --frozen git-cliff --tag "$TAG_NAME" --prepend CHANGELOG.md "${PREV_TAG}..HEAD"
else
uv run git-cliff --tag "$TAG_NAME" --output CHANGELOG.md
uv run --frozen git-cliff --tag "$TAG_NAME" --output CHANGELOG.md
fi

- name: Commit changelog
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ FROM builder AS builder-slim
RUN --mount=type=cache,target=/root/.cache/uv \
--mount=type=bind,source=uv.lock,target=uv.lock \
--mount=type=bind,source=pyproject.toml,target=pyproject.toml \
uv sync --frozen --no-install-project --no-dev --no-editable
uv sync --frozen --no-build --no-install-project --no-dev --no-editable

# Then, add the rest of the project source code and install it
# Installing separately from its dependencies allows optimal layer caching
Expand Down Expand Up @@ -59,7 +59,7 @@ FROM builder AS builder-all
RUN --mount=type=cache,target=/root/.cache/uv \
--mount=type=bind,source=uv.lock,target=uv.lock \
--mount=type=bind,source=pyproject.toml,target=pyproject.toml \
uv sync --frozen --no-install-project --all-extras --no-dev --no-editable
uv sync --frozen --no-build --no-install-project --all-extras --no-dev --no-editable

# Then, add the rest of the project source code and install it
# Installing separately from its dependencies allows optimal layer caching
Expand Down
Loading