fix(ci): resolve SonarQube security issues in workflows and Dockerfile#625
Open
olivermeyer wants to merge 2 commits intomainfrom
Open
fix(ci): resolve SonarQube security issues in workflows and Dockerfile#625olivermeyer wants to merge 2 commits intomainfrom
olivermeyer wants to merge 2 commits intomainfrom
Conversation
External-deps-only stages (--no-install-project) can safely enforce wheel-only installs. Stages that install the local project annotated with NOSONAR since the local build is trusted source code and --frozen already enforces lockfile hash verification. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
olivermeyer
requested review from
a team and
helmut-hoffer-von-ankershoffen
as code owners
Makes the lockfile invariant explicit on every uv run call that follows uv sync --frozen, preventing any inadvertent environment update and resolving the SonarQube "unlocked dependency" warnings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
SonarQube flagged two Medium/Major security issues across CI workflows and the Dockerfile:
uv syncwithout--no-build(allowing potential build-script execution from source distributions) anduv runwithout--frozen(potentially allowing silent environment updates before running a command).How?
Dockerfile stages that use
--no-install-projectinstall only external dependencies, so--no-buildcan safely enforce wheel-only installs there. The remaininguv syncissues (workflow files and Dockerfile stages that installaignosticsitself) are marked as accepted in SonarQube —aignosticsmust be built from source as no pre-built binary distribution exists. Alluv runcalls in workflow files gain--frozen, making the lockfile invariant explicit at every invocation.