Add CheckPrerequisite to WorkflowStep to validate state machine edges#374
Open
Zoe Zhao (zoez7) wants to merge 2 commits into
Open
Add CheckPrerequisite to WorkflowStep to validate state machine edges#374Zoe Zhao (zoez7) wants to merge 2 commits into
Zoe Zhao (zoez7) wants to merge 2 commits into
Conversation
Zoe Zhao (zoez7)
force-pushed
the
check-prerequisite
branch
4 times, most recently
from
9e8acdf to
3921ac8
Compare
Zoe Zhao (zoez7)
commented
Jul 8, 2026
| } | ||
| func (s *AssignWorkerStep) CheckPrerequisite(ctx context.Context, input *ResumeInput, state *ResumeState) error { | ||
| // The resume edge exists from SUSPENDED and PAUSED. | ||
| // RESUMING is allowed for retrying this step. |
Collaborator
Author
There was a problem hiding this comment.
This is because of line 168 below.
| func (s *FinalizeSuspendedStep) Name() string { return "FinalizeSuspended" } | ||
| func (s *FinalizeSuspendedStep) IsComplete(ctx context.Context, input *SuspendInput, state *SuspendState) (bool, error) { | ||
| // The workflow is completely done ONLY if the status is SUSPENDED *and* we've successfully freed the worker. | ||
| return state.Actor.GetStatus() == ateapipb.Actor_STATUS_SUSPENDED && state.Actor.GetAteomPodNamespace() == "", nil |
Collaborator
Author
There was a problem hiding this comment.
I removed this check, because we actually update the Actor's status and worker assignment in the same UpdateActor request in Execute() below, so we only need to check if status==suspended.
Zoe Zhao (zoez7)
force-pushed
the
check-prerequisite
branch
from
3921ac8 to
ec3b70c
Compare
Zoe Zhao (zoez7)
force-pushed
the
check-prerequisite
branch
from
ec3b70c to
4104a7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #369
Add a CheckPrerequisite method to the WorkflowStep interface, called by RunWorkflow after IsComplete returns false and before Execute, so that each workflow validates its actor state-machine edge up front while retried (reentrant) workflows still fast-forward past completed steps.