Skip to content

chore: additional shadow dom tests and fixes - #9632

Open
snowystinger wants to merge 36 commits into
mainfrom
additional-shadow-dom-tests
Open

chore: additional shadow dom tests and fixes#9632
snowystinger wants to merge 36 commits into
mainfrom
additional-shadow-dom-tests

Conversation

@snowystinger

@snowystinger snowystinger commented Feb 10, 2026

Copy link
Copy Markdown
Member

Closes #10330

Pulling in various tests from all the PRs that have preceded this one.
First set from #8991

Need to figure out some oddities in the tests, esp Popover, why does it fail in React 16 and how does it pass in the non-shadow dom enabled test

  • Resolution, cannot support React 16 as the way it aggregates event handlers doesn't work with Shadow DOM

Another issue solved, I've fixed focus in preventFocus for Combobox in real life. I was able to test it in the browser tests.

I also noticed that RangeCalendar has a bug, one click will start and finish the range immediately. I've added a test and fixed this as well.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

You can test the ComboBox and DateRangePicker in the new aggregate S2 ShadowDOM story. If you find other bugs I don't mention or test in here, please still report it, but it'll be follow up elsewhere.

🧢 Your Project:

@github-actions github-actions Bot added the RAC label Feb 10, 2026
@snowystinger snowystinger mentioned this pull request Feb 10, 2026
5 tasks
@rspbot

rspbot commented Feb 12, 2026

Copy link
Copy Markdown

@snowystinger snowystinger mentioned this pull request Feb 12, 2026
5 tasks
@rspbot

rspbot commented Feb 12, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Feb 12, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Feb 12, 2026

Copy link
Copy Markdown

@yihuiliao yihuiliao removed the v3 label Feb 12, 2026
@rspbot

rspbot commented Feb 13, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Mar 26, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Mar 31, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Mar 31, 2026

Copy link
Copy Markdown

# Conflicts:
#	packages/react-aria/src/interactions/utils.ts
#	packages/react-aria/test/focus/FocusScope.test.js
#	packages/react-aria/test/overlays/useOverlay.test.js
@rspbot

rspbot commented Aug 7, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Aug 7, 2026

Copy link
Copy Markdown

@snowystinger snowystinger changed the title chore: additional shadow dom tests chore: additional shadow dom tests and fixes Aug 7, 2026
@rspbot

rspbot commented Aug 7, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Aug 12, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Aug 12, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Aug 12, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (2)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/62ba81625d11bdd5c7c871ba50e11cebf1c7e54e/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/62ba81625d11bdd5c7c871ba50e11cebf1c7e54e/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RangeCalendar inside shadow DOM commits range on first click (endDragging uses retargeted e.target)

3 participants