fix(RangeCalendar): use getEventTarget for shadow DOM compatibility - #10449
Closed
waterWang wants to merge 1 commit into
Closed
fix(RangeCalendar): use getEventTarget for shadow DOM compatibility#10449waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
When RangeCalendar is rendered inside a shadow root, the window-level pointerup listener (endDragging) reads e.target directly. In shadow DOM, events are retargeted so e.target is the shadow host, not the actual calendar cell button. This causes nodeContains to always return false, and commitSelection() runs on every single click, immediately committing start === end. Fix: use the existing getEventTarget helper which reads e.composedPath()[0] from the event, giving the actual target element even inside shadow DOM. Closes adobe#10330
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
When
RangeCalendaris rendered inside a shadow root, the window-levelpointeruplistener (endDragging) readse.targetdirectly. In shadow DOM, events are retargeted soe.targetis the shadow host, not the actual calendar cell button. This causesnodeContains(ref.current, target)to always returnfalse, andcommitSelection()runs on every single click — immediately committingstart === end.Fix
Used the existing
getEventTargethelper from@react-aria/src/utils/shadowdom/DOMFunctionswhich readse.composedPath()[0]from the event, giving the actual target element even inside shadow DOM.Related issue
Closes #10330