Skip to content

chore: fix so that TSDiff doesnt return non-existant layout changes #10059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snowystinger merged 2 commits into from
May 13, 2026
+5 −1
Merged

chore: fix so that TSDiff doesnt return non-existant layout changes #10059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18e4a51
chore: fix so that TSDiff doesnt return non-existant layout changes
LFDanLu May 12, 2026
481101a
Merge branch 'main' into fix_tsdiff_type_processing
LFDanLu May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/dev/parcel-transformer-docs/DocsTransformer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,11 @@ module.exports = new Transformer({
);
}

if (path.isTSExpressionWithTypeArguments()) {
// due to oxlint formatting, WaterfallLayout/other classes now are multiline declarations
// the "extends Layout<Node<T>, 0>" part then ends up becoming isTSInstantiationExpressions superclass rather than just Identifier.
// as a result, should be handled similar to isTSExpressionWithTypeArguments (aka Blah<T>)
// see https://astexplorer.net/#/gist/451958d4b4a31868f0896664e2291a92/15ffdc9fe4097cfdb9f997f12d550fdff4761205 for verification
if (path.isTSExpressionWithTypeArguments() || path.isTSInstantiationExpression()) {
if (path.node.typeParameters) {
return Object.assign(node, {
type: 'application',
Expand Down