chore: fix so that TSDiff doesnt return non-existant layout changes#10059
Open
LFDanLu wants to merge 2 commits into
Open
chore: fix so that TSDiff doesnt return non-existant layout changes#10059LFDanLu wants to merge 2 commits into
LFDanLu wants to merge 2 commits into
Conversation
differ was claiming that the layouts lost getVisibleLayoutInfos, virtualizer but that turned out to be that it wasnt processing the Layout extends properly anymore via DocsTransformer
|
Build successful! 🎉 |
snowystinger
approved these changes
May 12, 2026
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
well that's annoying that whitespace changes its type
|
Build successful! 🎉 |
yihuiliao
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSDiffer was claiming that the layouts lost
getVisibleLayoutInfos/virtualizer/etc from their API but it turned out to be that DocsTransformer wasn't processing the Layout extends properly anymore via DocsTransformer since it became multiline from the oxlint formatting changesSee https://astexplorer.net/#/gist/451958d4b4a31868f0896664e2291a92/15ffdc9fe4097cfdb9f997f12d550fdff4761205 for a validation of what Layout's ast returns (click on
Layoutfor the multilineListLayoutdefinition vs the single lineListLayoutdefintion)✅ Pull Request Checklist:
📝 Test Instructions:
Check the TSDiff reported and verify that the changes look correct
🧢 Your Project:
RSP