Skip to content

fix(http-client): fix relative redirects #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobil4sk wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(http-client): fix relative redirects #2227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f335062
fix(http-client): fix relative redirects
tobil4sk Jan 3, 2026
244c274
tests(http-client): add relative redirect case
tobil4sk Jan 3, 2026
ab0011e
tests(http-client): add mixed redirect case
tobil4sk Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/http-client/__tests__/basics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,28 @@ describe('basics', () => {
expect(obj.url).toBe('https://postman-echo.com/get')
})

it('does basic get request with relative redirects', async () => {
const res: httpm.HttpClientResponse = await _http.get(
'https://postman-echo.com/redirect-to?url=get'
)
expect(res.message.statusCode).toBe(200)
const body: string = await res.readBody()
const obj = JSON.parse(body)
expect(obj.url).toBe('https://postman-echo.com/get')
})

it('does basic get request with hostname and relative redirects', async () => {
const res: httpm.HttpClientResponse = await _http.get(
`https://postman-echo.com/redirect-to?url=${encodeURIComponent(
'https://www.postman-echo.com/redirect-to?url=get'
)}`
)
expect(res.message.statusCode).toBe(200)
const body: string = await res.readBody()
const obj = JSON.parse(body)
expect(obj.url).toBe('https://www.postman-echo.com/get')
})

it('does basic get request with redirects (303)', async () => {
const res: httpm.HttpClientResponse = await _http.get(
`https://postman-echo.com/redirect-to?url=${encodeURIComponent(
Expand Down
2 changes: 1 addition & 1 deletion packages/http-client/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ export class HttpClient {
// if there's no location to redirect to, we won't
break
}
const parsedRedirectUrl = new URL(redirectUrl)
const parsedRedirectUrl = new URL(redirectUrl, info.parsedUrl)
if (
parsedUrl.protocol === 'https:' &&
parsedUrl.protocol !== parsedRedirectUrl.protocol &&
Expand Down