fix(http-client): fix relative redirects #2227
Open
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the relative redirect location is relative to the previous url, not the original url.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the HTTP client where relative redirects would fail. The fix provides a base URL to the URL constructor when parsing redirect URLs, allowing it to correctly resolve relative paths.
- Adds base URL parameter to URL constructor for redirect URL parsing
- Adds comprehensive test coverage for relative redirect scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/http-client/src/index.ts | Fixed URL constructor call to handle relative redirects by passing the current URL as base |
| packages/http-client/tests/basics.test.ts | Added two new test cases for relative redirects and chained redirects with hostname changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #2226
This solves the root cause of the bug, but for tool-cache to work correctly, the tool-cache's http-client version needs to be updated with this patch.
URL constructor parameter documentation can be found here:
https://developer.mozilla.org/en-US/docs/Web/API/URL/URL#parameters