-
Notifications
You must be signed in to change notification settings - Fork 45
new doc AFF support #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
new doc AFF support #300
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| title: Adding AFF support | ||
| category: serializers | ||
| order: 35 | ||
| --- | ||
|
|
||
| The [ABAP File Format (AFF)](https://github.com/SAP/abap-file-formats) is the preferred | ||
| format for object types for which SAP provides an AFF object handler. | ||
|
|
||
| For implementing AFF support for new object types already supported by AFF see the examples in the repository. | ||
|
|
||
| abapGit has been backwards compatible for 10+ years, and whishes to continue to support all users going forward. | ||
| This means reading old formats and writing new formats, and not breaking existing users, and users should not loose any data when switching to a new format. | ||
|
|
||
| Suggested approach: | ||
|
|
||
| * Read the old XML into the new AFF format carried by the INTF, https://github.com/abapGit/abapGit/tree/main/src/objects/aff_types | ||
| * Persist the object given the data in the INTF | ||
| * Serialize the object to AFF format | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should define which part gets implemented in which class ie what changes need to be made to the old class and what needs to be changed in the framework around it (and we assume a new AFF class has been provided by SAP that calls the AFF handler which might not be the case). That's what I tried to discuss in abapGit/abapGit#7768 |
||
| Make sure to test and keep old and new examples in https://github.com/orgs/abapGit-tests | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading needs to support both xml and json formats.