new doc AFF support - #300
Open
larshp wants to merge 2 commits into
Open
Conversation
mbtools
reviewed
Jul 30, 2026
|
|
||
| Suggested approach: | ||
|
|
||
| * Read the old XML into the new AFF format carried by the INTF, https://github.com/abapGit/abapGit/tree/main/src/objects/aff_types |
Member
There was a problem hiding this comment.
Reading needs to support both xml and json formats.
| * Read the old XML into the new AFF format carried by the INTF, https://github.com/abapGit/abapGit/tree/main/src/objects/aff_types | ||
| * Persist the object given the data in the INTF | ||
| * Serialize the object to AFF format | ||
|
|
Member
There was a problem hiding this comment.
We should define which part gets implemented in which class ie what changes need to be made to the old class and what needs to be changed in the framework around it (and we assume a new AFF class has been provided by SAP that calls the AFF handler which might not be the case).
That's what I tried to discuss in abapGit/abapGit#7768
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.