Skip to content

[UDFS] Fix NULL-free in UDFBuildHashEntry to prevent BSOD (0xC4/0x10) #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 11 commits into
base: udf-dev
Choose a base branch
from
Draft

[UDFS] Fix NULL-free in UDFBuildHashEntry to prevent BSOD (0xC4/0x10) #216

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b9d68f3
refactoring
assorted Nov 1, 2025
a3a7243
try-fix-write
assorted Dec 25, 2025
cffe655
refactoring
assorted Feb 2, 2026
a3305a9
UDFInsertPrefix
assorted Feb 14, 2026
c56cb49
Initial plan
Copilot Apr 6, 2026
b2e30f3
[UDFS] Add NULL guard in UDFDOSName to prevent BSOD on shutdown
Copilot Apr 6, 2026
d0a5c76
[UDFS] Fix NULL-free in UDFBuildHashEntry causing BSOD (0xC4/0x10)
Copilot Apr 6, 2026
e6abf08
Revert "[UDFS] Fix NULL-free in UDFBuildHashEntry causing BSOD (0xC4/…
Zero3K20 Apr 15, 2026
991f517
Merge branch 'udf-dev' of https://github.com/zero3k20/reactos into ud…
Zero3K20 Apr 27, 2026
9423589
Merge origin/udf-dev and re-apply NULL guard fix in UDFDOSName
Copilot Apr 27, 2026
25c7f67
[UDFS] Fix NULL-free in UDFBuildHashEntry by moving free to success b…
Copilot Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions drivers/filesystems/udfs/udf_info/dirtree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,9 +398,11 @@ UDFBuildHashEntry(
UName.MaximumLength = Name->Length;
UName.Buffer = (PWCHAR)FsRtlAllocatePoolWithTag(NonPagedPool, UName.MaximumLength, TAG_FILE_NAME);

RtlUpcaseUnicodeString(&UName, Name, FALSE);
hashes->hLfn = crc32((uint8*)(UName.Buffer), UName.Length);
ExFreePoolWithTag(UName.Buffer, TAG_FILE_NAME);
if (UName.Buffer) {
RtlUpcaseUnicodeString(&UName, Name, FALSE);
hashes->hLfn = crc32((uint8*)(UName.Buffer), UName.Length);
ExFreePoolWithTag(UName.Buffer, TAG_FILE_NAME);
}
}

if (Mask & HASH_DOS) {
Expand Down